Skip to content

Conversation

@RecuencoJones
Copy link
Owner

Add active object for storing plugin settings in repository.
Add enabled checkbox.

@RecuencoJones RecuencoJones force-pushed the feature/add-active-object branch from 063350e to fb4cf64 Compare March 21, 2020 19:19
@RecuencoJones RecuencoJones requested a review from ainochu March 21, 2020 20:36
final RepositoryCloneSettings settings = repositoryCloneSettingsDAO.get(repositoryID);

log.info("Repository {}/{} cloned", projectKey, repositorySlug);
if (settings != null && settings.isEnabled()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a separate method to validate it.

final String projectKey = repository.getProject().getKey();
final RepositoryCloneSettings settings = repositoryCloneSettingsDAO.get(repositoryID);

if (settings != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same stuff here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants